smiklosovic commented on code in PR #2505:
URL: https://github.com/apache/cassandra/pull/2505#discussion_r1272542857
##########
test/distributed/org/apache/cassandra/distributed/impl/Instance.java:
##########
@@ -923,6 +923,8 @@ public Future<Void> shutdown(boolean graceful)
error = parallelRun(error, executor, this::stopJmx);
+ DatabaseDescriptor.getCryptoProvider().uninstall();
Review Comment:
If we catch it then what do you want to do with that ... to log it? So we do
all the stuff but crypto provider will remain to be installed. Then on the next
test this will fail horribly (been there, done that) because it will use old
crypto provider with new classloader of new Instance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
