smiklosovic commented on code in PR #2505: URL: https://github.com/apache/cassandra/pull/2505#discussion_r1272552515
########## src/java/org/apache/cassandra/security/InBuiltJREProvider.java: ########## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.security; + +import java.util.Map; + +/** + * Crypto provider which does nothing. Handy for situations when a user + * wants to completely bypass crypto provider installation. + */ +public final class InBuiltJREProvider extends AbstractCryptoProvider Review Comment: It was called like that :D But we came to conclusion with Mick that _NoOpCryptoProvider_ sounds like you are going to use a provider which is _not doing any crypto at all_. Calling it like this means that you will get same crypto which is in JVM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
