smiklosovic commented on code in PR #2505:
URL: https://github.com/apache/cassandra/pull/2505#discussion_r1272565412
##########
.build/parent-pom-template.xml:
##########
@@ -233,12 +233,52 @@
<id>zznate</id>
<name>Nate McCall</name>
</developer>
+ <developer>
+ <id>smiklosovic</id>
+ <name>Stefan Miklosovic</name>
+ </developer>
</developers>
<scm>
<connection>scm:https://gitbox.apache.org/repos/asf/cassandra.git</connection>
<developerConnection>scm:https://gitbox.apache.org/repos/asf/cassandra.git</developerConnection>
<url>https://gitbox.apache.org/repos/asf?p=cassandra.git;a=tree</url>
</scm>
+
+ <profiles>
+ <profile>
+ <id>x86_64</id>
+ <activation>
+ <os>
+ <arch>!aarch64</arch>
Review Comment:
What other types, like 32 bits? Does Cassandra even run on 32 bits anyway? I
would just keep it like this.
If we run this like ... on FreeBSD, it will put x86 lib on the class path,
then it will try to load it and it will presumably fail and log will be printed.
I do not think anybody will ever build Cassandra with Maven on FreeBSD or
any other unix for that matter. Like ...why? People are going to at most run it
(if even that) and they are covered already as they will have it in
`lib/x86_64` or `lib/aarch64`. So them running Cassandra on these platforms
will not have any library added to the class path and again this is catched by
the exception handling we have in place for the provider.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
