adelapena commented on PR #2506:
URL: https://github.com/apache/cassandra/pull/2506#issuecomment-1651399406
```
// if the other node is pre-4.0, it will respond only with its
maxMessagingVersion
if (maxMessagingVersion < VERSION_40 || handshakeMessagingVersion <
VERSION_40)
return new Accept(useMessagingVersion, maxMessagingVersion);
```
> Should we return null for this case? This is the HandshakeProtocol class.
> changing that breaks HandshakeTest 🤷
Returning null there doesn't break `HandshakeTest` for me, at least locally.
What failure are you finding?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
