michaelsembwever commented on code in PR #2506:
URL: https://github.com/apache/cassandra/pull/2506#discussion_r1274945141
##########
src/java/org/apache/cassandra/net/Message.java:
##########
@@ -1287,7 +986,7 @@ private Map<ParamType, Object>
deserializeParams(DataInputPlus in, int version)
*/
private Map<ParamType, Object> extractParams(ByteBuffer buf, int
readerIndex, int version) throws IOException
{
- long count = version >= VERSION_40 ? getUnsignedVInt(buf,
readerIndex) : buf.getInt(readerIndex);
+ long count = getUnsignedVInt(buf, readerIndex);
Review Comment:
done
##########
src/java/org/apache/cassandra/net/ParamType.java:
##########
@@ -40,25 +39,17 @@
* will skip over any params it doesn't recognise.
*
* Please don't add boolean params here. Extend and use {@link MessageFlag}
instead.
+ *
+ * Do not re-use old, nor fill gaps in the sequence of, ids. New IDs must be
higher.
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
