frankgh commented on code in PR #51:
URL: https://github.com/apache/cassandra-sidecar/pull/51#discussion_r1279934347
##########
build.gradle:
##########
@@ -72,11 +77,22 @@ allprojects {
excludeFilter = file("${project.rootDir}/spotbugs-exclude.xml")
}
- tasks.withType(com.github.spotbugs.SpotBugsTask) {
+ tasks.withType(SpotBugsTask) {
reports.xml.enabled = false
reports.html.enabled = true
}
+ codeCheckTasks.dependsOn(tasks.withType(Checkstyle))
+ codeCheckTasks.dependsOn(tasks.withType(RatTask))
+ codeCheckTasks.dependsOn(tasks.withType(SpotBugsTask))
+
+ tasks.withType(Test) {
+ shouldRunAfter(codeCheckTasks)
+ shouldRunAfter(tasks.withType(Checkstyle))
+ shouldRunAfter(tasks.withType(RatTask))
+ shouldRunAfter(tasks.withType(SpotBugsTask))
+ }
+
Review Comment:
I think it is described in line 59:
> // Force checkstyle, rat, and spotBugs to run before test tasks for faster
feedback
Just tried running `./gradlew test` locally (by removing license header from
a couple of java files), and it doesn't modify the test behavior.
`./gradlew check` fails fast before running tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
