JeetKunDoug commented on code in PR #51:
URL: https://github.com/apache/cassandra-sidecar/pull/51#discussion_r1280714140
##########
src/test/integration/org/apache/cassandra/sidecar/testing/CassandraSidecarTestContext.java:
##########
@@ -142,6 +182,8 @@ public String toString()
public void close()
{
instancesConfig.instances().forEach(instance ->
instance.delegate().close());
+ // TODO: Do we need to close sessions?
+// sessionProviders.
Review Comment:
To be a bit more specific, I'm fairly certain that shutting down the Sidecar
server itself will eventually close these, but in case somehow the sidecar
server doesn't, it makes sense to close them explicitly here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
