ekaterinadimitrova2 commented on code in PR #2563:
URL: https://github.com/apache/cassandra/pull/2563#discussion_r1290647228
##########
bin/cassandra.in.sh:
##########
@@ -125,9 +125,6 @@ short=$(echo "${jvmver}" | cut -c1-2)
JAVA_VERSION=17
if [ "$short" = "11" ] ; then
JAVA_VERSION=11
-elif [ "$JVM_VERSION" \< "17" ] ; then
- echo "Cassandra 5.0 requires Java 11 or Java 17."
- exit 1;
Review Comment:
The side effect of this removal is that for any version between Java 11 and
17, JAVA_VERSION will be set to 17, no?
Then the jvm options files for Java 17 will be used for versions pre-17. In
my opinion we should use the Java 11 files for those JDK versions and the J17
files for any >= J17 version. Look here -
https://github.com/apache/cassandra/blob/trunk/bin/cassandra.in.sh#L152-L158
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
