michaelsembwever commented on code in PR #2563:
URL: https://github.com/apache/cassandra/pull/2563#discussion_r1296850162
##########
bin/cassandra.in.sh:
##########
@@ -125,9 +125,6 @@ short=$(echo "${jvmver}" | cut -c1-2)
JAVA_VERSION=17
if [ "$short" = "11" ] ; then
JAVA_VERSION=11
-elif [ "$JVM_VERSION" \< "17" ] ; then
Review Comment:
are there any existing checks/conditions for when JVM_VERSION is greater
than 17 ?
instead of introducing a flag, i'd be ok with
- preventing JDKs 12-16
- printing a loud warning when 18+ is used
I'm ~ok when extending the latter to failure, and using the `-J` to make it
work (with the loud warning)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
