smiklosovic commented on code in PR #2563:
URL: https://github.com/apache/cassandra/pull/2563#discussion_r1329221617
##########
tools/bin/cassandra.in.sh:
##########
@@ -82,13 +82,24 @@ jvmver=`echo "$java_ver_output" | grep '[openjdk|java]
version' | awk -F'"' 'NR=
JVM_VERSION=${jvmver%_*}
short=$(echo "${jvmver}" | cut -c1-2)
-JAVA_VERSION=17
if [ "$short" = "11" ] ; then
JAVA_VERSION=11
elif [ "$JVM_VERSION" \< "17" ] ; then
echo "Cassandra 5.0 requires Java 11 or Java 17(or newer)."
+ exit
fi
+# Allow execution if a supported Java version is used or CASSANDRA_USE_ALL_JDK
argument is set
+java_versions_supported=11,17
+supported_version=$(echo "$java_versions_supported" | tr "," '\n' | grep -F -x
"$short")
+
+if [ "x$CASSANDRA_USE_ALL_JDK" != "xtrue" ] && [ "x$supported_version" = "x" ]
; then
+ echo "Cassandra 5.0 requires Java 11, Java 17 (or newer LTS)."
+ echo "If you would like to test with other Java versions >17, set
\$CASSANDRA_USE_ALL_JDK=true"
Review Comment:
there should be space between `Java versions >` and `17` like this: `Java
versions > 17`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
