dchenbecker commented on code in PR #2593:
URL: https://github.com/apache/cassandra/pull/2593#discussion_r1300190058
##########
build.xml:
##########
@@ -90,7 +90,10 @@
<property name="test.jvm.args" value="" />
<property name="testtag.extra" value="" />
<property name="dist.dir" value="${build.dir}/dist"/>
- <property name="tmp.dir" value="${java.io.tmpdir}"/>
+
+ <!-- Use build/tmp for temp files if not otherwise specified. Because Ant
properties are immutable, this has no effect if
+ the user specifies the tmp.dir property -->
+ <property name="tmp.dir" value="${build.dir}/tmp"/>
Review Comment:
Basically, the property defines what is used for the `java.io.tmpdir`
property in testing. Ant properties are immutable, so if someone provides the
property on the command line (e.g. `ant -Dtmp.dir=/tmp/mytests ...`) then line
96 has no effect and the tests will use the provided directory. Now that you've
mentioned it, though, I should make a change so that this honors the previous
definition, which would use any provided `java.io.tmpdir` property on the
command line. I can make it conditional so that we'll still use
`${build.dir}/tmp` if `java.io.tmpdir` is not provided
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
