dchenbecker commented on code in PR #2593:
URL: https://github.com/apache/cassandra/pull/2593#discussion_r1300196069
##########
build.xml:
##########
@@ -90,7 +90,10 @@
<property name="test.jvm.args" value="" />
<property name="testtag.extra" value="" />
<property name="dist.dir" value="${build.dir}/dist"/>
- <property name="tmp.dir" value="${java.io.tmpdir}"/>
+
+ <!-- Use build/tmp for temp files if not otherwise specified. Because Ant
properties are immutable, this has no effect if
+ the user specifies the tmp.dir property -->
+ <property name="tmp.dir" value="${build.dir}/tmp"/>
Review Comment:
Actually, that won't work since we're running inside `ant` and the property
will always be set since it's the JVM. I can't think of a way to differentiate
between a JVM default `java.io.tmpdir` and one that was passed on the ant
command line...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
