dchenbecker commented on code in PR #2593:
URL: https://github.com/apache/cassandra/pull/2593#discussion_r1300601387
##########
test/unit/org/apache/cassandra/audit/AuditLoggerTest.java:
##########
@@ -59,17 +59,17 @@
public class AuditLoggerTest extends CQLTester
{
@BeforeClass
- public static void setUp()
+ public static void setUp() throws IOException
{
- AuditLogOptions options = new AuditLogOptions();
+ AuditLogOptions options = getBaseAuditLogOptions();
options.enabled = true;
options.logger = new ParameterizedClass("InMemoryAuditLogger", null);
DatabaseDescriptor.setAuditLoggingOptions(options);
requireNetwork();
}
@Before
- public void beforeTestMethod()
+ public void beforeTestMethod() throws IOException
{
AuditLogOptions options = new AuditLogOptions();
Review Comment:
I actually started that refactor at first and then stopped because I wasn't
sure whether consistency trumped minimizing changes. Happy to do that work if
we all agree it's the right thing to do
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
