dcapwell commented on code in PR #57:
URL: https://github.com/apache/cassandra-accord/pull/57#discussion_r1301999265
##########
accord-core/src/main/java/accord/local/PreLoadContext.java:
##########
@@ -52,6 +54,17 @@ public interface PreLoadContext
*/
default Collection<TxnId> additionalTxnIds() { return
Collections.emptyList(); }
+ default Collection<TxnId> txnIds()
+ {
+ TxnId primaryTxnId = primaryTxnId();
+ Collection<TxnId> additional = additionalTxnIds();
Review Comment:
let me make sure I am clear
```
if (primaryTxnId == null) return additional
if (additional.isEmpty) return Collections.single(primaryTxnId)
return new LooksLikeAArray(primaryTxnId, additionalTxnIds)
```
if so, I don't mind making that change, if not would need to better get
where you are coming from
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
