belliottsmith commented on code in PR #57:
URL: https://github.com/apache/cassandra-accord/pull/57#discussion_r1301845319
##########
accord-core/src/main/java/accord/local/PreLoadContext.java:
##########
@@ -52,6 +54,17 @@ public interface PreLoadContext
*/
default Collection<TxnId> additionalTxnIds() { return
Collections.emptyList(); }
+ default Collection<TxnId> txnIds()
+ {
+ TxnId primaryTxnId = primaryTxnId();
+ Collection<TxnId> additional = additionalTxnIds();
Review Comment:
If we're adding a default method here, would prefer not to copy all contents
to a list when we know it's either additional or additional +1. Why not extend
`AbstractCollection`? Or `AbstractList` would be cleaner, if we can restrict
`additionalTxnIds()` to `List`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
