smiklosovic commented on code in PR #2620:
URL: https://github.com/apache/cassandra/pull/2620#discussion_r1302965782


##########
.build/build-sonar.xml:
##########
@@ -0,0 +1,167 @@
+<?xml version="1.0" encoding="UTF-8" standalone="no"?>
+<!--
+  ~ Licensed to the Apache Software Foundation (ASF) under one
+  ~ or more contributor license agreements.  See the NOTICE file
+  ~ distributed with this work for additional information
+  ~ regarding copyright ownership.  The ASF licenses this file
+  ~ to you under the Apache License, Version 2.0 (the
+  ~ "License"); you may not use this file except in compliance
+  ~ with the License.  You may obtain a copy of the License at
+  ~
+  ~     http://www.apache.org/licenses/LICENSE-2.0
+  ~
+  ~ Unless required by applicable law or agreed to in writing, software
+  ~ distributed under the License is distributed on an "AS IS" BASIS,
+  ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  ~ See the License for the specific language governing permissions and
+  ~ limitations under the License.
+  -->
+<project basedir="." name="apache-cassandra-sonar-tasks" xmlns:if="ant:if" 
xmlns:unless="ant:unless">
+    <property name="sonar-scanner-cli.version" value="5.0.1.3006-linux"/>
+    <property name="sonar.workdir" value="${build.dir}/sonar"/>
+    <property name="sonar.download.dir" 
value="${user.home}/.cassandra-cache/tools"/>
+    <property name="sonar-scanner.home" 
value="${sonar.download.dir}/sonar-scanner-${sonar-scanner-cli.version}"/>

Review Comment:
   @jacek-lewandowski maybe putting it all to `/tmp` would be OK too? That 
would still cache it, kind of, even though it would not survive the restart of 
the developer's PC.
   
   @Mmuzaf I think that we can do an exception like this. OWASP cache literally 
just downloads data from the OWASP server. It just downloads the repository of 
CVEs. There is nothing project-specific (as in Cassandra project) which we need 
to have `realclean` for.
   
   Checkstyle is something different, isnt it? That cache is project specific. 
I mean ... its content depends on how the sources look like.
   
   Anyway I think that moving it to /tmp is a nice compromise.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to