Mmuzaf commented on code in PR #2620: URL: https://github.com/apache/cassandra/pull/2620#discussion_r1303031008
########## .build/build-sonar.xml: ########## @@ -0,0 +1,167 @@ +<?xml version="1.0" encoding="UTF-8" standalone="no"?> +<!-- + ~ Licensed to the Apache Software Foundation (ASF) under one + ~ or more contributor license agreements. See the NOTICE file + ~ distributed with this work for additional information + ~ regarding copyright ownership. The ASF licenses this file + ~ to you under the Apache License, Version 2.0 (the + ~ "License"); you may not use this file except in compliance + ~ with the License. You may obtain a copy of the License at + ~ + ~ http://www.apache.org/licenses/LICENSE-2.0 + ~ + ~ Unless required by applicable law or agreed to in writing, software + ~ distributed under the License is distributed on an "AS IS" BASIS, + ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + ~ See the License for the specific language governing permissions and + ~ limitations under the License. + --> +<project basedir="." name="apache-cassandra-sonar-tasks" xmlns:if="ant:if" xmlns:unless="ant:unless"> + <property name="sonar-scanner-cli.version" value="5.0.1.3006-linux"/> + <property name="sonar.workdir" value="${build.dir}/sonar"/> + <property name="sonar.download.dir" value="${user.home}/.cassandra-cache/tools"/> + <property name="sonar-scanner.home" value="${sonar.download.dir}/sonar-scanner-${sonar-scanner-cli.version}"/> + <property name="sonar.projectKey" value="cassandra"/> + <property name="sonar.mainBranch" value="trunk"/> + + <target name="sonar-init"> + <mkdir dir="${sonar.download.dir}"/> + <mkdir dir="${sonar-scanner.home}"/> + <mkdir dir="${sonar.workdir}"/> + <mkdir dir="${sonar.workdir}/scanner"/> + <mkdir dir="${sonar.workdir}/data"/> + <mkdir dir="${sonar.workdir}/logs"/> + <mkdir dir="${sonar.workdir}/extensions"/> + </target> + + <target name="init-sonar-scanner-cli" depends="sonar-init" unless="sonar-scanner.downloaded"> + <local name="sonar-scanner.downloaded"/> + <available file="${sonar-scanner.home}/bin/sonar-scanner" property="sonar-scanner.downloaded"/> + + <sequential unless:set="sonar-scanner.downloaded"> + <echo>Downloading Sonar-Scanner CLI...</echo> + <retry retrycount="3" retrydelay="5000" > + <get src="https://binaries.sonarsource.com/Distribution/sonar-scanner-cli/sonar-scanner-cli-${sonar-scanner-cli.version}.zip"; + dest="${sonar.download.dir}/sonar-scanner-cli-${sonar-scanner-cli.version}.zip"/> + </retry> + <unzip src="${sonar.download.dir}/sonar-scanner-cli-${sonar-scanner-cli.version}.zip" dest="${sonar.download.dir}" overwrite="true"/> + <setpermissions mode="755"> + <!-- unzip task in Ant does not preserve file permissions, so we need to make those files executable explicitly --> + <file file="${sonar-scanner.home}/bin/sonar-scanner" /> + <file file="${sonar-scanner.home}/jre/bin/java" /> + <file file="${sonar-scanner.home}/jre/lib/jspawnhelper" /> + </setpermissions> + </sequential> + </target> + + <macrodef name="check-server-status"> + <attribute name="url"/> + <sequential> + <exec executable="bash" failifexecutionfails="true" failonerror="true" logerror="false"> + <arg value="-c"/> + <arg value="curl -s "@{url}/api/system/status" | jq -r ".status" | grep UP"/> + </exec> + </sequential> + </macrodef> + + <target name="init-sonar-server" depends="sonar-init,maybe-set-sonar-server-url,maybe-start-sonar-server"> + <check-server-status url="${sonar.host.url}"/> + </target> + + <target name="maybe-set-sonar-server-url" depends="sonar-init" if="env.SONAR_SERVER_URL"> + <property name="sonar.host.url" value="${env.SONAR_SERVER_URL}"/> + <fail unless="env.SONAR_CASSANDRA_TOKEN" message="SONAR_CASSANDRA_TOKEN environment variable must be set when using Sonar server defined in env SONAR_SERVER_URL"/> + <property name="sonar.token" value="${env.SONAR_CASSANDRA_TOKEN}"/> + </target> + + <target name="maybe-start-sonar-server" depends="sonar-init" unless="env.SONAR_SERVER_URL"> + <property name="sonar.host.url" value="http://127.0.0.1:9000"/> + <local name="sonar-server.running"/> + <condition property="sonar-server.running" value="true"> + <socket server="127.0.0.1" port="9000"/> + </condition> + <antcall target="start-sonarqube" unless:set="sonar-server.running" inheritrefs="true"/> + + <exec executable="bash" failifexecutionfails="false" failonerror="true" logerror="false"> + <arg line="-c"/> + <arg value="curl -s -u admin:password -X POST '${sonar.host.url}/api/user_tokens/revoke?name=cassandra'"/> + </exec> + + <exec executable="bash" failifexecutionfails="true" failonerror="true" logerror="false"> + <arg line="-c"/> + <arg value="curl -s -u admin:password -X POST '${sonar.host.url}/api/user_tokens/generate?name=cassandra&type=GLOBAL_ANALYSIS_TOKEN' | jq -r '.token'"/> + <redirector outputproperty="sonar.token"/> + </exec> + </target> + + <target name="start-sonarqube" depends="sonar-init"> + <exec executable="docker" dir="${sonar.workdir}" failifexecutionfails="true" failonerror="true" logerror="true"> Review Comment: Can we report the prepared result to the console? While the docker is running I think we can fetch all the results from the API and push them to the console. The two things that concern me the most: - We leave unclosed resources after the build process. To me, the `ant` is a build tool, and not designed to be a server-like script when we initiate something to start like a daemon; - Another point is if it leaves the resources unclosed, it will probably only be used on local machines, which, in turn, concerns why not just use simple `bash` instead, like in-tree scripts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
