jacek-lewandowski commented on code in PR #2620: URL: https://github.com/apache/cassandra/pull/2620#discussion_r1303028298
########## .build/build-sonar.xml: ########## @@ -0,0 +1,167 @@ +<?xml version="1.0" encoding="UTF-8" standalone="no"?> +<!-- + ~ Licensed to the Apache Software Foundation (ASF) under one + ~ or more contributor license agreements. See the NOTICE file + ~ distributed with this work for additional information + ~ regarding copyright ownership. The ASF licenses this file + ~ to you under the Apache License, Version 2.0 (the + ~ "License"); you may not use this file except in compliance + ~ with the License. You may obtain a copy of the License at + ~ + ~ http://www.apache.org/licenses/LICENSE-2.0 + ~ + ~ Unless required by applicable law or agreed to in writing, software + ~ distributed under the License is distributed on an "AS IS" BASIS, + ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + ~ See the License for the specific language governing permissions and + ~ limitations under the License. + --> +<project basedir="." name="apache-cassandra-sonar-tasks" xmlns:if="ant:if" xmlns:unless="ant:unless"> + <property name="sonar-scanner-cli.version" value="5.0.1.3006-linux"/> + <property name="sonar.workdir" value="${build.dir}/sonar"/> + <property name="sonar.download.dir" value="${user.home}/.cassandra-cache/tools"/> + <property name="sonar-scanner.home" value="${sonar.download.dir}/sonar-scanner-${sonar-scanner-cli.version}"/> Review Comment: I see your point and I don't want to make anything that would break working with multiple project worktrees, hence we are discussing. Though: 1. the server needs to be running in order to browse the results, there can be an Ant task to stop it 2. When working with multiple worktrees, starting a new server for each worktree could be confusing, we can easily confuse which port was used for which project worktree 3. We do not necessarily setup volumes assuming that we will not reuse the results later, this would fix the problem of storing data in the build directory and exposing to problems when trying to clean the build directory while the server is still working. We would not need to store the data outside the project worktree. 4. In order to reuse the server for multiple project worktrees, we could create a project in Sonar per project worktree. The only question would be the name of the project - branch name would not be sufficient because, as you mentioned, you operate on more than one `trunk`, which is totally justified. Perhaps branch name and sha? Or Git worktree name? 5. OWASP cache will be more like Maven repository, I don't think we would want to clean it because it is branch-agnostic. It also ~ 500MB database. wdyt? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
