maedhroz commented on code in PR #2645:
URL: https://github.com/apache/cassandra/pull/2645#discussion_r1312172906
##########
src/java/org/apache/cassandra/index/sai/utils/PrimaryKey.java:
##########
@@ -61,11 +83,15 @@ public PrimaryKey createTokenOnly(Token token)
return new TokenOnlyPrimaryKey(token);
}
+ /**
+ * Create a {@link PrimaryKey} for tables without clustering columns
+ */
public PrimaryKey createPartitionKeyOnly(DecoratedKey partitionKey)
Review Comment:
nit: For `createTokenOnly()` and `createPartitionKeyOnly()`, I wouldn't be
sad if we just overloaded `create()`, given the JavaDoc and the arguments make
it pretty clear what we can possibly create. Not a big deal either way though...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
