mike-tr-adamson commented on code in PR #2645:
URL: https://github.com/apache/cassandra/pull/2645#discussion_r1312838720
##########
src/java/org/apache/cassandra/index/sai/plan/QueryController.java:
##########
@@ -215,7 +216,12 @@ private ClusteringIndexFilter makeFilter(PrimaryKey key)
{
ClusteringIndexFilter clusteringIndexFilter =
command.clusteringIndexFilter(key.partitionKey());
- if (key.hasEmptyClustering())
+ assert cfs.metadata().comparator.size() == 0 &&
!key.kind().isClustering ||
+ cfs.metadata().comparator.size() > 0 && key.kind().isClustering
:
+ "PrimaryKey " + key + " clustering does not match table. There
should be a clustering of size " + cfs.metadata().comparator.size();
+
+ // TODO How do we avoid iterating the whole partition for static rows?
Review Comment:
I think this is exactly what I wanted. The comment was really for me to
think about the impact of querying on a static column index. Of course, the
result is going to be that the whole partition matches and should be returned.
I'll put this change in and see how the testing goes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
