mike-tr-adamson commented on code in PR #2645:
URL: https://github.com/apache/cassandra/pull/2645#discussion_r1312846241


##########
src/java/org/apache/cassandra/index/sai/disk/v1/segment/SegmentMetadata.java:
##########
@@ -201,6 +204,19 @@ private static void writeBytes(ByteBuffer buf, IndexOutput 
out)
         }
     }
 
+    private static void writeBytes(byte[] bytes, IndexOutput out)
+    {
+        try
+        {
+            out.writeInt(bytes.length);
+            out.writeBytes(bytes, 0, bytes.length);
+        }
+        catch (IOException ioe)
+        {
+            throw new RuntimeException(ioe);

Review Comment:
   I have changed this to `Throwables.unchecked`. This is what we do with these 
everywhere else so seems the right thing to do here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to