adelapena commented on code in PR #2673:
URL: https://github.com/apache/cassandra/pull/2673#discussion_r1333417858
##########
src/java/org/apache/cassandra/db/ReadQuery.java:
##########
@@ -256,4 +256,12 @@ default void maybeValidateIndex()
default void trackWarnings()
{
}
+
+ /**
+ * @return true given read query is a top-k request
Review Comment:
Maybe we could add in the JavaDoc for this method that top-k queries are
necessarily based on the ordering provided by an index. Otherwise, the
implementation of this method in `ReadCommand` should be based on the
`RowFilter` expressions rather than delegating to the index.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
