mike-tr-adamson commented on code in PR #2673:
URL: https://github.com/apache/cassandra/pull/2673#discussion_r1337053163
##########
src/java/org/apache/cassandra/cql3/statements/SelectStatement.java:
##########
@@ -1573,6 +1656,39 @@ public int compare(List<ByteBuffer> a, List<ByteBuffer>
b)
}
}
+ private static class IndexColumnComparator<T> extends
ColumnComparator<List<ByteBuffer>>
+ {
+ private final SingleRestriction restriction;
+ private final int columnIndex;
+
+ // VSTODO maybe cache in prepared statement
+ public IndexColumnComparator(SingleRestriction restriction, int
columnIndex)
+ {
+ this.restriction = restriction;
+ this.columnIndex = columnIndex;
+ }
+
+ @Override
+ public boolean indexOrdering()
+ {
+ return true;
+ }
+
+ @Override
+ public Comparator<List<ByteBuffer>> prepareFor(TableMetadata table,
QueryOptions options)
+ {
+ Index index =
restriction.findSupportingIndex(IndexRegistry.obtain(table));
Review Comment:
I agree. I have added a `findSupportingIndexFromQueryPlan` to `Restriction`
and am using that here instead. While it is unlikely that this is a problem, it
is a good idea to have the index lookups consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
