adelapena commented on code in PR #2673: URL: https://github.com/apache/cassandra/pull/2673#discussion_r1333462103
########## src/java/org/apache/cassandra/index/sai/StorageAttachedIndex.java: ########## @@ -40,16 +41,21 @@ import java.util.stream.Collectors; import com.google.common.annotations.VisibleForTesting; +import com.google.common.base.Preconditions; import com.google.common.collect.ImmutableSet; import com.google.common.util.concurrent.Futures; // checkstyle: permit this import import com.google.common.util.concurrent.ListenableFuture; // checkstyle: permit this import import org.slf4j.Logger; import org.slf4j.LoggerFactory; +import io.github.jbellis.jvector.vector.VectorSimilarityFunction; Review Comment: CQL similarity functions (`org.apache.cassandra.cql3.functions.VectorFcts` and `org.apache.cassandra.cql3.functions.VectorFctsTest`) still import `org.apache.lucene.index.VectorSimilarityFunction`. They should be updated to import `io.github.jbellis.jvector.vector.VectorSimilarityFunction`. They also contain some vars named `luceneFunction` that should be renamed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
