mike-tr-adamson commented on code in PR #2673:
URL: https://github.com/apache/cassandra/pull/2673#discussion_r1337139772


##########
src/java/org/apache/cassandra/cql3/statements/SelectStatement.java:
##########
@@ -483,7 +486,7 @@ else if (restrictions.keyIsInRelation())
 
         // Please note that the isExhausted state of the pager only gets 
updated when we've closed the page, so this
         // shouldn't be moved inside the 'try' above.
-        if (!pager.isExhausted())
+        if (!pager.isExhausted() && !pager.pager.isTopK())

Review Comment:
   The query issues were a 2 part problem in the `VectorQueryController`. 
   1. The code to establish whether a query was a hybrid query or not did not 
consider whether the other expressions in the query were indexed or not.
   2. The code to build the iterators was not checking for indexed expressions 
correctly.
   
   The `UOE` on flush is not reproducing locally, and the test with flush is 
running correctly. I can only assume that this has been fixed elsewhere.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to