mike-tr-adamson commented on code in PR #2673:
URL: https://github.com/apache/cassandra/pull/2673#discussion_r1341262017
##########
src/java/org/apache/cassandra/db/marshal/VectorType.java:
##########
@@ -365,6 +366,7 @@ public abstract class VectorSerializer extends
TypeSerializer<List<T>>
public abstract <V> List<V> split(V buffer, ValueAccessor<V> accessor);
public abstract <V> V serializeRaw(List<V> elements, ValueAccessor<V>
accessor);
+ public abstract float[] deserializeFloatArray(ByteBuffer input);
Review Comment:
No, `composeAsFloat` composes a `float[]` for the specific `VectorType`. As
in, it uses the `dimension` specified for the `VectorType` instance this is
called on. The `deserializeFloatArray` method is not specific to single
instance and gets the dimension from the buffer passed to is that was
previously generated by a call to `serialize`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
