skoppu22 commented on code in PR #2648:
URL: https://github.com/apache/cassandra/pull/2648#discussion_r1332988830


##########
test/unit/org/apache/cassandra/tools/nodetool/InvalidateCIDRPermissionsCacheTest.java:
##########
@@ -142,11 +142,15 @@ public void testInvalidateAllCidrPermissions()
         assertThat(roleA.hasAccessFromIp(ipAddr)).isTrue();
         assertThat(roleB.hasAccessFromIp(ipAddr)).isTrue();
         
assertThat(originalReadsCount).isEqualTo(getCidrPermissionsReadCount());
+        assertThat(((CassandraCIDRAuthorizer) 
DatabaseDescriptor.getCIDRAuthorizer()).has(ROLE_A)).isTrue();

Review Comment:
   As mentioned above, this unit test just invokes AuthCache's invalidate() 
function which re-inits the cache. So we don't need has(role) function.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to