amitdpawar commented on code in PR #2777:
URL: https://github.com/apache/cassandra/pull/2777#discussion_r1350351308
##########
src/java/org/apache/cassandra/db/commitlog/CommitLogSegment.java:
##########
@@ -138,7 +139,8 @@ static CommitLogSegment createSegment(CommitLog commitLog,
AbstractCommitLogSegm
Configuration config = commitLog.configuration;
CommitLogSegment segment = config.useEncryption() ? new
EncryptedSegment(commitLog, manager)
:
config.useCompression() ? new CompressedSegment(commitLog, manager)
-
: new MemoryMappedSegment(commitLog, manager);
+
: ! config.isDirectIOEnabled() ? new MemoryMappedSegment(commitLog,
manager)
Review Comment:
will update as per the suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
