Maxwell-Guo commented on code in PR #2777:
URL: https://github.com/apache/cassandra/pull/2777#discussion_r1350425801


##########
src/java/org/apache/cassandra/config/DatabaseDescriptor.java:
##########
@@ -2649,6 +2649,11 @@ public static void setCommitLogSegmentSize(int 
sizeMebibytes)
         conf.commitlog_segment_size = new 
DataStorageSpec.IntMebibytesBound(sizeMebibytes);
     }
 
+    public static boolean getDirectIOStatus()

Review Comment:
   it is only for commitlog , and besides I think the function name can 
describe status more accurately than getDirectIOStatus, as a boolean value has 
only true or false. And I don't known what does true /false stands for in IO 
status.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to