smiklosovic commented on code in PR #2786:
URL: https://github.com/apache/cassandra/pull/2786#discussion_r1350760188
##########
src/java/org/apache/cassandra/cql3/statements/schema/TableAttributes.java:
##########
@@ -185,6 +208,26 @@ private Map<String, String> getMap(Option option)
return value;
}
+ private boolean hasStringValue(Option option)
+ {
+ Object val = properties.get(option.toString());
+ if (val != null && val instanceof String)
Review Comment:
@Maxwell-Guo why do you use if / else? the result of `val != null && val
instanceof String` is a boolean as such, `hasMapValue` method same case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
