Maxwell-Guo commented on code in PR #2786:
URL: https://github.com/apache/cassandra/pull/2786#discussion_r1360812756
##########
src/java/org/apache/cassandra/schema/SchemaEvent.java:
##########
@@ -248,6 +249,14 @@ private HashMap<String, Serializable>
repr(CompressionParams compr)
return ret;
}
+ private HashMap<String, Serializable> repr(SSTableFormatParams
sstableFormat)
+ {
+ HashMap<String, Serializable> ret = new HashMap<>();
+ if (sstableFormat == null) return ret;
+ ret.putAll(sstableFormat.asMap());
Review Comment:
that's to say : 1. this should be removed or left empty (I got what you mean
now);2. if node_a and node_b have different parameters in cassandra.yaml for
sstable_format with the same name bti-fast, and we create tableA in node_a with
bit-fast, then there may be two situations:
a ) node_a's configuration for bti-fast,e.g. `create table xxx with
sstable_format = 'bti-fast'` can just match the create table's ddl , we can use
node_a's yaml, and node_b will use node_b's yaml as the type for ddl is
bti-fast and fortunately we got bti-fast configuration in node_b' yaml;
b) node_a's have bti-fast 's configurations but the ddl only set the type
but the parameters are not same with configuration, so we will use user's
defined parameter, and node_b will use the yaml's configuration of his own , if
node_b don't have bti-fast's configuration , the default configuration will be
used.
is that all right ? @blambov
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
