Maxwell-Guo commented on code in PR #2786:
URL: https://github.com/apache/cassandra/pull/2786#discussion_r1363348923
##########
src/java/org/apache/cassandra/db/memtable/Flushing.java:
##########
@@ -104,6 +104,7 @@ static FlushRunnable flushRunnable(ColumnFamilyStore cfs,
Directories.DataDirectory flushLocation)
{
Memtable.FlushablePartitionSet<?> flushSet =
memtable.getFlushSet(from, to);
+ // TODO make this per table ,use table's sstable_format type
Review Comment:
we may need to merge the configured value and cql defined value, not using
the
[sstableFormats](https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/config/DatabaseDescriptor.java#L226)
for different custom-type, if we want to sstable format options to be the
latest.As the option value in sstableFormats may not be the latest. And what
are the
[options](https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/io/sstable/format/AbstractSSTableFormat.java#L27)
used for ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
