amitdpawar commented on code in PR #2777:
URL: https://github.com/apache/cassandra/pull/2777#discussion_r1362031099
##########
src/java/org/apache/cassandra/db/commitlog/CommitLog.java:
##########
@@ -129,6 +131,25 @@ private static CommitLog construct()
// register metrics
metrics.attach(executor, segmentManager);
+
+ String diskMode = " ";
+
+ switch (DatabaseDescriptor.getCommitLogDiskAccessMode())
+ {
+ case standard:
+ diskMode = "Standard (buffered)";
+ break;
+ case mmap:
+ diskMode = "MMap(memory mmaped)";
+ break;
+ case direct_io:
+ diskMode = "Direct (non-buffered)";
+ break;
+ default:
+ throw new IllegalArgumentException("Unknown commitlog disk
access mode type: " + DatabaseDescriptor.getCommitLogDiskAccessMode());
Review Comment:
I think this is required and right place to show disk access mode and replay
warn log when Direct-IO is used. Is this OK ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
