amitdpawar commented on code in PR #2777: URL: https://github.com/apache/cassandra/pull/2777#discussion_r1362037318
########## test/conf/cassandra.yaml: ########## @@ -8,6 +8,7 @@ memtable_allocation_type: offheap_objects commitlog_sync: batch commitlog_segment_size: 5MiB commitlog_directory: build/test/cassandra/commitlog +commitlog_disk_access_mode : mmap Review Comment: > commit log is mmap by default, so I don't think we need this , am I right ? I included for future usage if someone wants to change and test. Please suggest and will change as per the suggestion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
