amitdpawar commented on code in PR #2777:
URL: https://github.com/apache/cassandra/pull/2777#discussion_r1361981532


##########
src/java/org/apache/cassandra/db/commitlog/CommitLog.java:
##########
@@ -684,5 +713,32 @@ public EncryptionContext getEncryptionContext()
         {
             return encryptionContext;
         }
+
+        /**
+         * Returns Direct-IO/non-buffer used for CommitLog IO.
+         * @return Direct-IO used for CommitLog IO
+         */
+        public boolean isDirectIOEnabled()
+        {
+            return diskAccessMode == Config.CommitLogDiskAccessMode.direct_io;
+        }
+
+        /**
+         * Returns MMAP used for CommitLog IO.
+         * @return MMAP used for CommitLog IO
+         */
+        public boolean isMMAPEnabled()
+        {
+            return diskAccessMode == Config.CommitLogDiskAccessMode.mmap;
+        }
+
+        /**
+         * Returns Standard or buffered I/O used for CommitLog IO.
+         * @return Standard or buffered I/O used for CommitLog IO
+         */
+        public boolean isBufferedIOEnabled()
+        {
+            return diskAccessMode == Config.CommitLogDiskAccessMode.standard;
+        }

Review Comment:
   It was needed to test Compressed and Encrypted to compare standard vs 
Direct-IO. It might be required in future but not now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to