blambov commented on code in PR #2777: URL: https://github.com/apache/cassandra/pull/2777#discussion_r1371737336
########## conf/cassandra.yaml: ########## @@ -589,6 +589,10 @@ commitlog_segment_size: 32MiB # parameters: # - +# Configure commitlog disk access mode preferred order:direct_io, mmap, standard. +# Default access mode is mmap. Direct I/O uses minimum page size to flush to disk. +commitlog_disk_access_mode : mmap Review Comment: My personal preference would be not only to change the default, but to scrap memory-mapped logs altogether. However, for things like these we can't change the default unless everyone agrees or there's no expected downside. In this case a downside is the fact that a memory-mapped log might effectively persist data more often in the default periodic mode. `mmap` should thus remain default, with a switch to `direct` as one of the items in the optimized configuration envisioned by CASSANDRA-18753. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
