amitdpawar commented on PR #2777:
URL: https://github.com/apache/cassandra/pull/2777#issuecomment-1780801409
> One more idea from me is to put sstable disk access mode under sstable
options and deprecate the current top-level `disk_access_mode`. That can be the
default for now, but we can let it be overwritten in sstable options. In
particular, there is an `sstable` of the `SSTableConfig` type. This is used to
select the default format and define per-format reader and writer options.
>
> It would be nice if, for a certain format, one could define in its options
things like: `data_read_access_mode`, `data_write_access_mode`,
`index_read_access_mode`, `index_write_access_mode`. For the new TrieIndex
format, that could even be separated for partition and row index. All of those
options are optional and hidden by default. However, for the new TrieIndex
format, they could be configured with the optimized values instead of legacy
defaults (in particular, their implicit values could be `auto` instead of
inheriting the value of deprecated `disk_access_mode` global option).
I think it is good to come up with such changes to have better control for
read/write to/from disk.
```
public static class SSTableConfig
{
public String selected_format = BigFormat.NAME;
public Map<String, Map<String, String>> format = new HashMap<>();
DiskAccessMode data_read_access_mode = DiskAccessMode.auto;
DiskAccessMode data_write_access_mode = DiskAccessMode.auto;
DiskAccessMode index_read_access_mode = DiskAccessMode.auto;
DiskAccessMode index_write_access_mode = DiskAccessMode.auto;
}
public final SSTableConfig sstable = new SSTableConfig();
```
OK with this change? I am not sure whether this will affect other thing.
Please let me know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
