jacek-lewandowski commented on code in PR #2777:
URL: https://github.com/apache/cassandra/pull/2777#discussion_r1372816621
##########
src/java/org/apache/cassandra/config/Config.java:
##########
@@ -1149,6 +1151,13 @@ public enum DiskAccessMode
standard,
}
+ public enum CommitLogDiskAccessMode
+ {
+ standard,
Review Comment:
I'm still at the position we should have one enum which cover all the needed
cases and just validate that for certain uses.
Here in particular, it would be useful to add, as suggested by @blambov -
`legacy` or assume undefined value would denote that. On the other hand, it
would be useful to add `auto` for the new, optimized behavior.
When access mode is specified explicitly, and it is invalid for certain use,
for example - `direct` for compressed/encrypted commitlog, I would like to fail
the startup with configuration error rather than do something implicitly. In
other words, I wish Cassandra does not configure something implicitly unless we
explicitly specify something that suggest default, automatic or legacy behavior.
That applies to both commitlog and sstable data files, and maybe would be
useful to separate that configuration for read and write.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
