dcapwell commented on code in PR #2844:
URL: https://github.com/apache/cassandra/pull/2844#discussion_r1372133075
##########
src/java/org/apache/cassandra/repair/RepairMessageVerbHandler.java:
##########
@@ -286,27 +285,28 @@ public void doVerb(final Message<RepairMessage> message)
break;
case PREPARE_CONSISTENT_REQ:
-
ctx.repair().consistent.local.handlePrepareMessage(message.from(),
(PrepareConsistentRequest) message.payload);
+
ctx.repair().consistent.local.handlePrepareMessage(message);
break;
case PREPARE_CONSISTENT_RSP:
-
ctx.repair().consistent.coordinated.handlePrepareResponse((PrepareConsistentResponse)
message.payload);
+
ctx.repair().consistent.coordinated.handlePrepareResponse(message);
break;
case FINALIZE_PROPOSE_MSG:
-
ctx.repair().consistent.local.handleFinalizeProposeMessage(message.from(),
(FinalizePropose) message.payload);
+
ctx.repair().consistent.local.handleFinalizeProposeMessage(message);
break;
case FINALIZE_PROMISE_MSG:
-
ctx.repair().consistent.coordinated.handleFinalizePromiseMessage((FinalizePromise)
message.payload);
+
ctx.repair().consistent.coordinated.handleFinalizePromiseMessage(message);
break;
case FINALIZE_COMMIT_MSG:
-
ctx.repair().consistent.local.handleFinalizeCommitMessage(message.from(),
(FinalizeCommit) message.payload);
+
ctx.repair().consistent.local.handleFinalizeCommitMessage(message);
break;
case FAILED_SESSION_MSG:
FailSession failure = (FailSession) message.payload;
+ sendAck(message);
Review Comment:
prob could nack if we don't know the session... ack vs nack really doesn't
matter for IR as it doesn't wait for the result... the retries really are just
for stability and not for the senders benefit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
