dcapwell commented on code in PR #2844:
URL: https://github.com/apache/cassandra/pull/2844#discussion_r1372142300
##########
test/unit/org/apache/cassandra/repair/ConcurrentIrWithPreviewFuzzTest.java:
##########
@@ -62,7 +64,7 @@ public void concurrentIrWithPreview()
// cause a delay in validation to have more failing previews
closeables.add(cluster.nodes.get(pickParticipant(rs,
previewCoordinator, preview)).doValidation(next -> (cfs, validator) -> {
if
(validator.desc.parentSessionId.equals(preview.state.id))
- cluster.unorderedScheduled.schedule(() ->
next.accept(cfs, validator), 1, TimeUnit.HOURS);
+ delayValidation(cluster, ir, next, cfs, validator);
Review Comment:
this was a flakey issue that this patch discovered... with IR retries we can
have IR take longer than 1h, so waiting by time is unsafe and leads to flakey
builds... now we check IR state and keep retrying until IR completes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
