dcapwell commented on code in PR #2844:
URL: https://github.com/apache/cassandra/pull/2844#discussion_r1372144044
##########
test/unit/org/apache/cassandra/repair/FailingRepairFuzzTest.java:
##########
@@ -114,6 +114,7 @@ public void failingRepair()
}
cluster.processAll();
+
Assertions.assertThat(repair.state.isComplete()).describedAs("Repair job did
not complete, and no work is pending...").isTrue();
Review Comment:
added to produce a more useful error msg when repairs are not complete...
These classes all assume that nothing left to process means the repair is
complete, but it could also mean a bug in repair that will never get
recovered... in that case the repair is not complete and the error message is
hard to understand... so this new error message is trying to express this case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
