blambov commented on code in PR #2830:
URL: https://github.com/apache/cassandra/pull/2830#discussion_r1373217927
##########
src/java/org/apache/cassandra/db/rows/AbstractCell.java:
##########
@@ -114,14 +119,44 @@ public Cell<?> clone(ByteBufferCloner cloner)
// note: while the cell returned may be different, the value is the same,
so if the value is offheap it must be referenced inside a guarded context (or
copied)
public Cell<?> updateAllTimestamp(long newTimestamp)
{
- return new BufferCell(column, isTombstone() ? newTimestamp - 1 :
newTimestamp, ttl(), localDeletionTime(), buffer(), path());
+ CellPath newPath = null;
+ if (path() != null) {
+ byte[] newUUID = nextTimeUUIDAsBytes(newTimestamp);
+ newPath = CellPath.create(ByteBuffer.wrap(newUUID));
+ logger.debug("timestamp: {} newPath: {}", newTimestamp,
newPath.get(0));
+ }
+ return new BufferCell(column, isTombstone() ? newTimestamp - 1 :
newTimestamp, ttl(), localDeletionTime(), buffer(), newPath);
Review Comment:
Would this not change all cell paths, including the ones used in maps,
breaking them?
Shouldn't this be done by `ListType` rather than the generic `Cell`
implementation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
