dcapwell commented on code in PR #2830:
URL: https://github.com/apache/cassandra/pull/2830#discussion_r1387241323
##########
src/java/org/apache/cassandra/utils/TimeUUID.java:
##########
@@ -411,9 +437,28 @@ public static byte[] nextTimeUUIDAsBytes()
return
toBytes(rawTimestampToMsb(unixMicrosToRawTimestamp(nextUnixMicros())),
clockSeqAndNode);
}
+ public static byte[] nextTimeUUIDAsBytes(long unixMicrosAtLeast)
Review Comment:
this is unsafe in accord as it is:
1) based off the local node, doesn't act the same cross the cluster
2) shared by non-accord tables, so both are corrupting each other...
You really don't want this and instead want `unsafe(unixMicros)` which does
not use any state...
Now, you still have the issue that the `clockSeqAndNode` isn't the same, so
you have to solve that as well... if we used the instance that created the txn,
then that would make sense... else we would need to have a global one used by
all accord nodes so its consistent...
@belliottsmith thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
