henrikingo commented on code in PR #2830:
URL: https://github.com/apache/cassandra/pull/2830#discussion_r1374671728
##########
src/java/org/apache/cassandra/db/rows/AbstractCell.java:
##########
@@ -114,14 +119,44 @@ public Cell<?> clone(ByteBufferCloner cloner)
// note: while the cell returned may be different, the value is the same,
so if the value is offheap it must be referenced inside a guarded context (or
copied)
public Cell<?> updateAllTimestamp(long newTimestamp)
{
- return new BufferCell(column, isTombstone() ? newTimestamp - 1 :
newTimestamp, ttl(), localDeletionTime(), buffer(), path());
+ CellPath newPath = null;
+ if (path() != null) {
+ byte[] newUUID = nextTimeUUIDAsBytes(newTimestamp);
+ newPath = CellPath.create(ByteBuffer.wrap(newUUID));
+ logger.debug("timestamp: {} newPath: {}", newTimestamp,
newPath.get(0));
+ }
+ return new BufferCell(column, isTombstone() ? newTimestamp - 1 :
newTimestamp, ttl(), localDeletionTime(), buffer(), newPath);
Review Comment:
Correct. Fixed in the most recent push, although I still didn't make it into
a method of ListType class, just did `if(column.type...)` (Although this isn't
"the right way" to write OO, I somehow instinctively dislike moving 2-4 lines
to a completely separate file.)
I will look into Jacek's comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
