smiklosovic commented on code in PR #2863:
URL: https://github.com/apache/cassandra/pull/2863#discussion_r1382221329
##########
src/java/org/apache/cassandra/net/StartupClusterConnectivityChecker.java:
##########
@@ -82,6 +85,16 @@ public boolean execute(Set<InetAddressAndPort> peers,
Function<InetAddressAndPor
if (peers == null || this.timeoutNanos < 0)
return true;
+ // Check if there are any nodes which we know are running a version
prior to 4.0.
+ // We use this intead of Gossiper::hasMajorVersion3Nodes because in
the absence of version information for a peer
+ // we still prefer to run the startup connectivity check.
+ if
(gossiper.isUpgradingFromVersionLowerThan(CassandraVersion.CASSANDRA_4_0))
Review Comment:
@isaacreath you might still mock it but there would be one additional
parameter to `execute` method which would be a function taking
`CassandraVersion` and returning `boolean`: `(version) ->
yourMock.isUpgradingFromVersionLowerThan(version)`.
`execute` already takes a function as its second parameter anyway ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
