smiklosovic commented on code in PR #2863:
URL: https://github.com/apache/cassandra/pull/2863#discussion_r1382367984
##########
src/java/org/apache/cassandra/net/StartupClusterConnectivityChecker.java:
##########
@@ -77,11 +77,22 @@ public static StartupClusterConnectivityChecker create(long
timeoutSecs, boolean
* @return true if the requested percentage of peers are marked ALIVE in
gossip and have their connections opened;
* else false.
*/
- public boolean execute(Set<InetAddressAndPort> peers,
Function<InetAddressAndPort, String> getDatacenterSource)
+ public boolean execute(Set<InetAddressAndPort> peers,
Function<InetAddressAndPort, String> getDatacenterSource,
+ Predicate<CassandraVersion>
isUpgradingFromLowerVersionThan)
{
if (peers == null || this.timeoutNanos < 0)
return true;
+ // Check if there are any nodes which we know are running a version
prior to 4.0.
+ // We use this intead of Gossiper::hasMajorVersion3Nodes because in
the absence of version information for a peer
+ // we still prefer to run the startup connectivity check.
+ if
(isUpgradingFromLowerVersionThan.test(CassandraVersion.CASSANDRA_4_0))
+ {
+ logger.debug("Skipping startup connectivity check as some nodes
may be running Cassandra version 3 or older " +
+ "which does not support connectivity checking.");
Review Comment:
would you mind to align this with the string above?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
