smiklosovic commented on code in PR #2863:
URL: https://github.com/apache/cassandra/pull/2863#discussion_r1382368051
##########
test/unit/org/apache/cassandra/net/StartupClusterConnectivityCheckerTest.java:
##########
@@ -64,6 +70,17 @@ else if (peersC.contains(endpoint))
return null;
}
+ private static class MockIsUpgradingFromVersionLowerThan implements
Predicate<CassandraVersion> {
+ CassandraVersion clusterVersion;
+ MockIsUpgradingFromVersionLowerThan(CassandraVersion clusterVersion) {
+ this.clusterVersion = clusterVersion;
+ }
+ @Override
+ public boolean test(CassandraVersion other) {
+ return this.clusterVersion.compareTo(other) < 0;
Review Comment:
you technically do not need `this` here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
