jacek-lewandowski commented on code in PR #2777:
URL: https://github.com/apache/cassandra/pull/2777#discussion_r1374321685
##########
src/java/org/apache/cassandra/config/DatabaseDescriptor.java:
##########
@@ -511,6 +511,41 @@ else if (conf.commitlog_sync_period.toMilliseconds() != 0)
logger.debug("Syncing log with a period of {}",
conf.commitlog_sync_period.toString());
}
+ // Only mmap & Direct-I/O access modes are supported. Standard access
mode is preassumed if Compressed or Encrypted segment is used.
+ // This ensures default behavior is unchanged.
+ if (conf.commitlog_disk_access_mode != Config.DiskAccessMode.auto
+ && conf.commitlog_disk_access_mode != Config.DiskAccessMode.legacy
Review Comment:
The condition should rather unconditionally prevent `mmap_index_only`
Other options may be valid depending on the context - say whether we have
encryption/compression enabled or not, where valid does not necessarily mean
efficient - that is another story;
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
