smiklosovic commented on code in PR #2957:
URL: https://github.com/apache/cassandra/pull/2957#discussion_r1415525263
##########
pylib/cqlshlib/copyutil.py:
##########
@@ -2130,6 +2136,7 @@ def convert_unknown(val, ct=cql_type):
'map': convert_map,
'tuple': convert_tuple,
'frozen': convert_single_subtype,
+ VectorType.typename: convert_vector,
Review Comment:
@Maxwell-Guo you mean like using `convert_unknown` for vector and then
convert vector in it? That would make sense, sure. But on the other hand, are
not we abusing the usage of `convert_unknown` ? What is _unknown_ about
_vector_? Nothing ... vector is perfectly known. So why would we use
`convert_unknown` then ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
