smiklosovic commented on code in PR #2957:
URL: https://github.com/apache/cassandra/pull/2957#discussion_r1415533773
##########
pylib/cqlshlib/copyutil.py:
##########
@@ -2130,6 +2136,7 @@ def convert_unknown(val, ct=cql_type):
'map': convert_map,
'tuple': convert_tuple,
'frozen': convert_single_subtype,
+ VectorType.typename: convert_vector,
Review Comment:
@szymon-miezal I think that using literal for the sake of consistency is
just fine. It is not like this is ever going to be renamed to something else.
It will be `vector` pretty much for ever.
Another option is to use it like you did here completely everywhere for each
entry in this map.
EDIT:
But on the other hand, as you showed, "vector" probably does not play
together with this as it is FQCN in the driver which is quite unfortunate.
I dont think we have a luxury of fixing stuff in python driver just to use a
literal here ...
So, putting that to "convert_unknown" does not feel right as I described in
the previous comment to Maxwell and if what I wrote here is true that it seems
like what is there currently is the best option.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
